fix: scope nested child-session navigation correctly#23365
Open
doer-ee wants to merge 1 commit intoanomalyco:devfrom
Open
fix: scope nested child-session navigation correctly#23365doer-ee wants to merge 1 commit intoanomalyco:devfrom
doer-ee wants to merge 1 commit intoanomalyco:devfrom
Conversation
github-actions
Bot
added
needs:compliance
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
Contributor
|
The following comment was made by an LLM, it may be inaccurate: Based on my search, I found one potentially related PR:
The other PRs found (like #7756) are older feature additions for hierarchical session navigation but appear to be foundational work rather than duplicates of the current fix. |
github-actions
Bot
removed
the
needs:compliance
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
doer-ee
force-pushed
the
fix/nested-child-session-navigation
branch
2 times, most recently
from
7bcf1d3 to
6a46b4d
Compare
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <[email protected]>
doer-ee
force-pushed
the
fix/nested-child-session-navigation
branch
from
6a46b4d to
812695d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #15972
Type of change
What does this PR do?
This fixes nested child-session navigation in the TUI.
The bug was that child-session descent was computed from the wrong level once already inside a child session. As a result,
<leader>downcould enter a first-level child session, but it would fail to descend again into that child's own child session.This change scopes child descent to the currently focused session's direct children and keeps sibling cycling at the current depth. It also adds focused tests for nested child descent and sibling navigation behavior.
How did you verify your code works?
Ctrl+X,DownCtrl+X,Downnow enters the sub-subagentScreenshots / recordings
N/A - TUI navigation bug fix, no screenshot included
Checklist